Changed dotnet Encoding to System Locale Dependent#186
Merged
sriram-mv merged 6 commits intoaws:developfrom Aug 6, 2020
Merged
Changed dotnet Encoding to System Locale Dependent#186sriram-mv merged 6 commits intoaws:developfrom
sriram-mv merged 6 commits intoaws:developfrom
Conversation
sriram-mv
requested changes
Aug 4, 2020
sriram-mv
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issues
#184
aws/aws-sam-cli#2031
aws/aws-sam-cli#1164
aws/aws-toolkit-vscode#1144
Description of changes:
aws dotnet extension output encoding is Console.OutputEncoding which is not UTF-8 in Windows(with utf8 beta option turned off).
Changed decoding to match the extension's system locale dependent encoding.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.